Add lsq.GetVarianceCovarianceMap() - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add/expose
lsq.GetVarianceCovarianceMap()to get dict of covariances between refined parameters. Useful if we want to do error propagation for values calculated from refined parameters, like QPA weight-percent or unit cell volume.Currently the dict keys are tuples of parameter names, which will look like
("Scale_~", "a~~").They are constructed by calling
par->GetName()on the paired parameters.After vincefn/objcryst#78 we should change this to
par->GetParNameHierarchy()to still have exclusive names?