Repository navigation
Fix fixed bodies remaining in the active set - #1063
Open
matthew-walters wants to merge 1 commit into
Open
matthew-walters wants to merge 1 commit into
matthew-walters wants to merge 1 commit into
Conversation
matthew-walters
force-pushed
the
fix-1049-fixed-body-active-set
branch
from
November 4, 2026 19:24
56f6145 to
5ddbef4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1049.
When an awake dynamic body was changed to
Fixed, it was removed from its persistent island but remained in the active body set indefinitely.This routes the type change through the existing full island-removal path, which removes both persistent and active membership and repairs indices affected by swap-removal.
The regression verifies that:
Validation:
cargo test -p rapier3d --test persistent_islandscargo test -p rapier2d --libcargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo clippy -p rapier2d -p rapier3dgit diff --check