Repository navigation
docs: specify SQLite type for bare filename example - #1780
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v4 SQLite example supplies a bare
.dbfilename, but URI-pair mode passes it into the LOAD DATABASE grammar without a scheme. The published v4-dev JAR at main231ab86778ca5ffd7de40878714760c8b4860cdfexits 1 withError building inline commandatFROM tiny.dbwhen reproducing the example with a tiny self-authored SQLite file.Correction
Add the already-supported
--type sqliteflag to the example. The CLI then constructs a SQLite source URI; no implementation or inference behavior is changed.Validation
With a self-authored two-table SQLite database and fresh task-owned PostgreSQL 17.6 cluster (Java 26, matching official v4-dev JAR):
--dry-run: parser error, exit 1.--type sqlite,--dry-run: connections OK, exit 0.--dry-run, targeting a newly created empty database: exit 0; SQL queries verify both tables contain exactly the two expected rows.No user database/configuration or default PostgreSQL service was used. Documentation-only change; no full integration matrix or CI pass claimed.