Skip to content

Remove stale Streaming/OggVorbis exclude from Package.swift - #153

Open
KevinTCoughlin wants to merge 1 commit into
dimitris-c:mainfrom
KevinTCoughlin:fix/remove-stale-oggvorbis-exclude
Open

KevinTCoughlin wants to merge 1 commit into
dimitris-c:mainfrom
KevinTCoughlin:fix/remove-stale-oggvorbis-exclude

Conversation

@KevinTCoughlin

@KevinTCoughlin KevinTCoughlin commented Nov 6, 2026 •

Copy link
Copy Markdown

The AudioStreaming target excludes Streaming/OggVorbis, but that directory does not exist on main, at 1.4.5 or at 1.4.4. It was on the Ogg Vorbis feature branch (added in 448ad71) and removed in fcba80c before #122 merged. The exclude entry stayed in Package.swift.

Because of it, building AudioStreaming as the root package (swift build in this repo, or CI) prints an invalid exclude warning (file not found). Packages that depend on AudioStreaming don't see it, because SwiftPM doesn't show those warnings for dependencies.

The Ogg Vorbis code is unaffected. AudioStreaming/OggVorbis/VorbisFileDecoder.swift and Streaming/AudioPlayer/Processors/OggVorbisStreamProcessor.swift are not under the excluded path, so they were compiled before this change and still are.

Change: one line in Package.swift. No other files change and behavior is the same.

Tested on macOS (Xcode toolchain, Swift 6.3.3):

  • swift build on main: builds, with the invalid exclude warning.
  • swift build on this branch: builds, without the warning. All other warnings are the same as on main.
  • An app package that depends on AudioStreaming builds for the iOS Simulator against this branch.

🤖 Generated with Claude Code

AudioStreaming/Streaming/OggVorbis was removed before the Ogg Vorbis
support landed in dimitris-c#122; the decoder lives in AudioStreaming/OggVorbis and
the stream processor in Streaming/AudioPlayer/Processors, both of which
are compiled. The leftover exclude entry points at a path that does not
exist, so SwiftPM emits an invalid-exclude warning on every resolve for
every package that depends on AudioStreaming.

No behavior change: nothing under the excluded path exists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RQetM3A7aws53cE41m2cg4
@KevinTCoughlin
KevinTCoughlin marked this pull request as ready for review November 7, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant