fix(ios): warn on leftover transform/opacity in Fabric view recycling - #32
Draft
kosmydel wants to merge 1 commit into
Draft
fix(ios): warn on leftover transform/opacity in Fabric view recycling#32kosmydel wants to merge 1 commit into
kosmydel wants to merge 1 commit into
Conversation
Native layer writes bypass props, so updateProps can skip the rewrite on reuse. Detect this in DEBUG without resetting the layer so call sites can be fixed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DEBUG-only tripwire in
prepareForRecyclefor the Fabric recycle-pool leak class: native code stampslayer.transform/layer.opacityoutside props, Fabric reuses the view, andupdatePropsdiffs identity against identity and skips the write. Warns instead of resetting so the native call site can be fixed.Test steps
[FabricRecycleLeak]warning — leftover transform/opacity should be reset on unmount or the component opted out via+shouldBeRecycled.layer.transformon a View whose props are identity, recycle it, and check for[FabricRecycleLeak]in the console. Release builds should not log.Note
This does not sanitize the layer. Warnings are the signal to fix the root cause, not a production safety net.
Made with Cursor