Repository navigation
Fix Clippy CI workflow - #2666
Merged
Merged
Conversation
divergentdave
force-pushed
the
david/deny-warnings
branch
from
November 16, 2026 18:29
06efc3f to
7738ecc
Compare
tgeoghegan
reviewed
Nov 16, 2026
| @@ -37,14 +37,15 @@ jobs: | |||
| run: cargo install clippy-sarif sarif-fmt | |||
Contributor
There was a problem hiding this comment.
This change does what it wants to do an it should go forward, but I hadn't noticed until just now that we use this clippy-sarif thing. If we think it's valuable enough to deal with the dependency, then we should use it in all our Rust projects. If not, we should remove it.
I lean toward removing it, because I believe what this does is post comments to the PR timeline about clippy results. IMO that's noisy and not helpful, because I can see the clippy results just fine either in the "checks" tab or locally when I run clippy after noticing my PR fails due to lints.
tgeoghegan
approved these changes
Nov 16, 2026
This was referenced Nov 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the Clippy workflow fail when it encounters any warning.