Skip to content

Fix Clippy CI workflow - #2666

Merged
divergentdave merged 2 commits into
mainfrom
david/deny-warnings
Nov 16, 2026
Merged

divergentdave merged 2 commits into
mainfrom
david/deny-warnings

Conversation

@divergentdave

Copy link
Copy Markdown
Collaborator

This should make the Clippy workflow fail when it encounters any warning.

@divergentdave
divergentdave requested a review from a team as a code owner November 16, 2026 17:59
@@ -37,14 +37,15 @@ jobs:
run: cargo install clippy-sarif sarif-fmt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does what it wants to do an it should go forward, but I hadn't noticed until just now that we use this clippy-sarif thing. If we think it's valuable enough to deal with the dependency, then we should use it in all our Rust projects. If not, we should remove it.

I lean toward removing it, because I believe what this does is post comments to the PR timeline about clippy results. IMO that's noisy and not helpful, because I can see the clippy results just fine either in the "checks" tab or locally when I run clippy after noticing my PR fails due to lints.

@divergentdave
divergentdave merged commit cedb08b into main Nov 16, 2026
8 checks passed
@divergentdave
divergentdave deleted the david/deny-warnings branch November 16, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants