Repository navigation
experiment: make AggregationJobWriter writable once - #4979
Closed
tgeoghegan wants to merge 1 commit into
Closed
tgeoghegan wants to merge 1 commit into
tgeoghegan wants to merge 1 commit into
Conversation
I suspect that any given `AggregationJobWriter` instance only ever gets a single call to `write`. This commit panics if ever a second call is observed so I can prove that in CI. Not to be merged.
tgeoghegan
marked this pull request as draft
November 13, 2026 21:41
Contributor
Author
|
Indeed, this works, so I believe I'm going to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect that any given
AggregationJobWriterinstance only ever gets a single call towrite. This commit panics if ever a second call is observed so I can prove that in CI. Not to be merged.If I'm right (write) about this, then we can significantly simplify this module by making
writetakemut self.