Skip to content

experiment: make AggregationJobWriter writable once - #4979

Closed
tgeoghegan wants to merge 1 commit into
mainfrom
timg/agg-job-writer-oneshot
Closed

tgeoghegan wants to merge 1 commit into
mainfrom
timg/agg-job-writer-oneshot

Conversation

@tgeoghegan

Copy link
Copy Markdown
Contributor

I suspect that any given AggregationJobWriter instance only ever gets a single call to write. This commit panics if ever a second call is observed so I can prove that in CI. Not to be merged.

If I'm right (write) about this, then we can significantly simplify this module by making write take mut self.

I suspect that any given `AggregationJobWriter` instance only ever gets
a single call to `write`. This commit panics if ever a second call is
observed so I can prove that in CI. Not to be merged.
@tgeoghegan
tgeoghegan requested a review from a team as a code owner November 13, 2026 21:41
@tgeoghegan
tgeoghegan marked this pull request as draft November 13, 2026 21:41
@tgeoghegan

Copy link
Copy Markdown
Contributor Author

Indeed, this works, so I believe I'm going to make AggregationJobWriter::write consume self, and will collapse WriteState into AggregationJobWriter.

@tgeoghegan tgeoghegan closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant