Repository navigation
Scope Prettier with .prettierignore and check formatting in CI (Phase A1) - #150
Merged
Merged
Conversation
… A1) Prettier had no ignore file, so `prettier --check .` walked vendor/ and flagged 1,543 files. The ignore file excludes third-party, generated, and fixture files, Markdown (hand-wrapped prose), and SCSS (owned by Stylelint, whose rules Prettier's SCSS output breaks). The ten JSON and YAML files Prettier still flagged are reformatted; each parses to identical data. A format:check script now runs in CI's Quality job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=========================================
Coverage 88.28% 88.28%
Complexity 22 22
=========================================
Files 61 61
Lines 7290 7290
Branches 690 690
=========================================
Hits 6436 6436
Misses 291 291
Partials 563 563 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase A, ticket 1 of
docs/planning/refactor-and-standards-memo.md.Prettier had no ignore file, so
npx prettier --check .scannedvendor/and flagged 1,543 files. This PR:.prettierignore. It excludes:-list markers;codecov.yml,components.jsonand.planning/config.json. Each one parses to identical data before and after, checked withyaml.safe_load/json.loads.npm run format:check(prettier --check .) and runs it in CI's Quality job, so formatting can't drift again. It's also noted in CLAUDE.md.Validation
npm run format:check: "All matched files use Prettier code style!"npm run lint:css: unchanged, since the SCSS files are untouched.python3 tools/check-components.py: passes on the reformattedcomponents.json, which it only reads.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2
Generated by Claude Code