Skip to content

Scope Prettier with .prettierignore and check formatting in CI (Phase A1) - #150

Merged
dknauss merged 1 commit into
mainfrom
claude/keen-tesla-49orwb
Oct 14, 2026
Merged

dknauss merged 1 commit into
mainfrom
claude/keen-tesla-49orwb

Conversation

@dknauss

@dknauss dknauss commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Summary

Phase A, ticket 1 of docs/planning/refactor-and-standards-memo.md.

Prettier had no ignore file, so npx prettier --check . scanned vendor/ and flagged 1,543 files. This PR:

  • Adds .prettierignore. It excludes:
    • third-party, generated and build files;
    • lockfiles;
    • fixtures and snapshots, which are compared byte for byte;
    • Markdown, which is hand-wrapped prose using - list markers;
    • SCSS, which Stylelint owns. Prettier's SCSS output breaks 39 Stylelint rules.
  • Reformats the 10 JSON/YAML files Prettier still flagged: issue templates, four workflows, codecov.yml, components.json and .planning/config.json. Each one parses to identical data before and after, checked with yaml.safe_load / json.loads.
  • Adds npm run format:check (prettier --check .) and runs it in CI's Quality job, so formatting can't drift again. It's also noted in CLAUDE.md.

Validation

  • npm run format:check: "All matched files use Prettier code style!"
  • npm run lint:css: unchanged, since the SCSS files are untouched.
  • python3 tools/check-components.py: passes on the reformatted components.json, which it only reads.
  • Each reformatted file is data-identical to its previous version.

Checklist

  • No behavior change
  • CI enforces the new check

🤖 Generated with Claude Code

https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2


Generated by Claude Code

… A1)

Prettier had no ignore file, so `prettier --check .` walked vendor/ and
flagged 1,543 files. The ignore file excludes third-party, generated,
and fixture files, Markdown (hand-wrapped prose), and SCSS (owned by
Stylelint, whose rules Prettier's SCSS output breaks). The ten JSON and
YAML files Prettier still flagged are reformatted; each parses to
identical data. A format:check script now runs in CI's Quality job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.28%. Comparing base (4d638a2) to head (5e0ab7e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #150   +/-   ##
=========================================
  Coverage     88.28%   88.28%           
  Complexity       22       22           
=========================================
  Files            61       61           
  Lines          7290     7290           
  Branches        690      690           
=========================================
  Hits           6436     6436           
  Misses          291      291           
  Partials        563      563           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dknauss
dknauss marked this pull request as ready for review October 14, 2026 23:18
@dknauss
dknauss merged commit 79870a7 into main Oct 14, 2026
19 checks passed
@dknauss
dknauss deleted the claude/keen-tesla-49orwb branch October 14, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants