Repository navigation
Put research on a PHP 8.x floor on the roadmap - #154
Merged
Merged
Conversation
A pending todo holds the brief and the first findings: no performance gain, a few lines of leaner code, modest maintainability gains mostly from native types, and a real cost in sites left behind. It lists the research still needed before deciding. The roadmap's compatibility backlog points to it. Also ignores .claude/ in Prettier: Claude Code agent worktrees are whole checkouts and made format:check flag 110 files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2
Psalm tightening enforces the types a PHP 8.x floor would add, in CI rather than on users' servers, so no PHP 7.4 site is cut off. Recorded in the floor todo's recommendation, the roadmap entry, and the memo's Phase D. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=========================================
Coverage 88.28% 88.28%
Complexity 22 22
=========================================
Files 61 61
Lines 7290 7290
Branches 690 690
=========================================
Hits 6436 6436
Misses 291 291
Partials 563 563 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This puts the PHP 8.x floor question on the roadmap as research, with no decision made.
.planning/todos/pending/2026-10-14-research-php-8x-floor.md. It holds the first findings, checked againstmain:is_list_array(), would becomearray_is_list().switchcode formatchto replace..prettierignorenow ignores.claude/. Claude Code agent worktrees are whole checkouts, and they madeformat:checkflag 110 files locally.Validation
npm run format:check: passes, including with agent worktrees present.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01KbVuMPN7YTcV27vwsG3LZ2
Generated by Claude Code