Repository navigation
Fix building configs reloaded from YAML with date-range splits - #8
Merged
Merged
Conversation
…lits YAML has no tuple type, so the DMI config's tuple-range splits came back from config.yaml as lists and validate_splits rejected them. That broke --config config.yaml and --config mlflow:<run> for any config with date-range splits. SourceDataDataModule now normalises two-element lists to tuples before validating. The DMI round-trip test now builds the whole reloaded config instead of working around this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second failure when resuming intrigued-sow-455 with
--config mlflow:<run>on 27sj894 (after #7 fixed the 404):Cause: YAML has no tuple type. The DMI config's
(start, end)splits are written toconfig.yamland come back as lists, whichvalidate_splitsrejects. So any saved config with date-range splits could not be rebuilt, via--config config.yamlor--config mlflow:<run>. (tests/config/test_dmi.pyalready noted this and only rebuilt the callbacks.)Fix:
normalize_splitsturns two-element lists back into tuples;SourceDataDataModuleapplies it beforevalidate_splits.Testing
Experimentfrom intrigued-sow-455's downloadedconfig.yamlplusresume_training: splits are tuples, the MLflow logger targets the run, all callbacks build.normalize_splitsunit test; the DMI config now builds completely after a YAML round trip. Full suite: 172 passed, 5 skipped.🤖 Generated with Claude Code