Repository navigation
github-builder: add shared exporter construction with compression - #1397
Merged
crazy-max merged 1 commit intoOct 27, 2026
Merged
Conversation
Centralize image and local exporter settings for the build and bake workflows. Preserve existing defaults and support optional compression settings with CSV quoting for exporter values. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
github-builder-output-compression
branch
from
October 27, 2026 09:03
07ce423 to
bc965e8
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The focused helper, dependency updates, and supplied test coverage have no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds a shared exporter-construction helper for GitHub Builder’s build and Bake workflows, preserving existing exporter defaults while supporting optional image compression and CSV-safe values.
Changes:
- Adds image and local exporter construction with input validation and optional compression settings.
- Tests defaults, compression options, CSV escaping, and invalid inputs.
- Adds and locks the
csv-stringifydependency.
| File | Description |
|---|---|
yarn.lock |
Locks the new CSV serialization dependency. |
src/github-builder/build-output.ts |
Implements shared exporter construction and compression options. |
package.json |
Adds csv-stringify as a runtime dependency. |
__tests__/github-builder/build-output.test.ts |
Covers exporter policies, compression, escaping, and validation. |
Review effort: Balanced
vvoland
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to docker/github-builder#207
Centralize image and local exporter settings for the build and bake workflows. Preserve existing defaults and support optional compression settings with CSV quoting for exporter values.