Repository navigation
Conversation
BuildKit parses the query-format git context with Go's url.Query(), which decodes "+" as a space and treats "&", "=", "#", "%" and ";" as delimiters. Since tag refs are now passed verbatim (ref=refs/tags/...), a SemVer tag with build metadata such as v1.0.0+build.1 was resolved as "refs/tags/v1.0.0 build.1" and the build failed to load the source. Encode each query value with encodeURIComponent per path segment so "/" stays readable while every other reserved character round-trips. The fragment format is left untouched because BuildKit reads it without decoding. Fixes docker/github-builder#330 Signed-off-by: Kang Jaehong <sinoru@me.com>
sinoru
force-pushed
the
feature/fix-github-builder#330
branch
from
October 31, 2026 08:35
96a1cce to
2e27f81
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildKit parses the query-format git context with Go's url.Query(), which decodes "+" as a space and treats "&", "=", "#", "%" and ";" as delimiters. Since tag refs are now passed verbatim (ref=refs/tags/...), a SemVer tag with build metadata such as v1.0.0+build.1 was resolved as "refs/tags/v1.0.0 build.1" and the build failed to load the source.
Encode each query value with encodeURIComponent per path segment so "/" stays readable while every other reserved character round-trips. The fragment format is left untouched because BuildKit reads it without decoding.
Fixes docker/github-builder#330