Repository navigation
實質改題三題加 rev:2,使已遷移的舊答案失效(PR #23 Copilot 留言跟進) - #24
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes requiring readers to answer the three revised questions again.
No open issues 🎉
What changed in this PR
延續 PR #23 的修正,讓 PR #19 空窗期內已遷移的三題舊答案失效,避免未經確認的新動作被計為已完成。
變更:
- 為濃煙關門、綜合所得稅結算申報、眷屬依附加保三題加入
rev:2,使用新的:v2答案識別碼,要求讀者重新回答。 - 在轉換管線加入對應規則,確保重產保留修正;其餘四組同義改名的答案遷移不變。
| File | Description |
|---|---|
selfcheck.html |
三題加入 rev:2,不再沿用舊識別碼下的答案。 |
scripts/zh-tw/convert.mjs |
加入三題版本更新的轉換規則及原因註解。 |
Review effort: Balanced
…a3752d Glossary: the body text already uses Taiwan wording, so the README glossary drops the old-term aliases and index.html follows. Direct upstream doggy8088 81e167a..1a3752d (7 commits, PR doggy8088#24): adopts the rev:2 bump that invalidates migrated answers for three changed questions, the convert-pipeline protections, the offline skill zip builder (tools/skill/build.mjs, keeping this fork's text, source URL and licences) and the legal-text conversion rule; Taiwan's legal and institutional wording stays. Root upstream eternity4719 36c7856 is covered by 00c9919; issue eternity4719#176 is recorded but not adopted until the book covers it. The zh-TW locale check now also rejects 聯網, 會話, 壓縮包 and MIT 許可, and convert.mjs keeps the Taiwan wording of two selfcheck hints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
跟進 PR #23 的 Copilot review 留言(https://github.com/doggy8088/HowToLiveBetter/pull/23#discussion_r4523376378,中嚴重度),查證屬實:
PR #19 的遷移程式會在頁面載入時把讀者舊 key 的答案搬到新 key、刪舊 key 並存回 localStorage;PR #23 只從對照表移除三組映射,擋得住未來的遷移,但擋不住 PR #19 合併到 PR #23 合併之間那幾小時內、已經被遷移過的答案。那些讀者的自查頁仍會把三個未經確認的新動作計為已完成。
修正(只改管線層 scripts/zh-tw/convert.mjs,由管線重產;qid() 已支援 rev 後綴,上游 B 型肝炎題已有 rev:2 前例):
驗證:
Assisted-by: Muse