Name remaining mndiagram data and split its animation table - #3453
Merged
itsgrimetime merged 3 commits intoSep 13, 2026
Merged
Conversation
itsgrimetime
force-pushed
the
pr/mndiagram-data-names
branch
2 times, most recently
from
September 11, 2026 21:57
075cecb to
04e29af
Compare
- mnDiagram_804D6C10 -> mnDiagram_ScreenGObj: the grid screen's GObj, set in mnDiagram_CreateScreen and read by the input and popup procs. - mnDiagram_804D4FA4 -> mnDiagram_StringTerminator, after mnName_StringTerminator; drop the unused externs for the two anonymous .sdata strings that followed it. - mnDiagram_803EE768 -> mnDiagram_IntroAnim: AnimLoopSettings for the screen intro animation, paired with the existing exit-animation table. - mnDiagram_803EE728 -> mnDiagram_PopupTextOffsets: three offsets passed to lb_8000B1CC to place the popup's HSD_Text objects relative to their JObjs. main.dol OK; mndiagram remains 100% matched.
Replace the f32[9] mnDiagram_PopupExitAnimFrames blob with three AnimLoopSettings symbols (mnDiagram_PopupExitAnim, mnDiagram_ArrowAnim, mnDiagram_CursorAnim) and read them, mnDiagram_IntroAnim, and mnDiagram_PopupTextOffsets directly where the compiler allows it. The mnDiagram_AnimTable overlay remains for the accesses that must be addressed from the table base: the popup text offsets in mnDiagram_PopupAnimProc and mnDiagram_CreatePopupTexts, cursor_anim, and the assert strings in mnDiagram_CreatePopup. main.dol OK; mndiagram remains 100% matched.
itsgrimetime
force-pushed
the
pr/mndiagram-data-names
branch
from
September 12, 2026 17:42
04e29af to
3c7d5dc
Compare
itsgrimetime
marked this pull request as ready for review
September 12, 2026 19:05
itsgrimetime
enabled auto-merge (squash)
September 13, 2026 04:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mnDiagram_AnimTableoverlay only for accesses that must be addressed from the contiguous table baseVerification
upstream/master; the previously stacked Name the mndiagram fighter and name display-order arrays #3451 history is no longer part of this PRninjapython configure.py progress08e0bf20134dfcb260699671004527b2d6bb1a45git diff --check