gr: Mostly document GroundParam - #3465
Draft
RighteousRyan1 wants to merge 1 commit into
Draft
RighteousRyan1 wants to merge 1 commit into
RighteousRyan1 wants to merge 1 commit into
Conversation
Author
|
VS chose not to rename references to said parameters. Will re-PR tomorrow. |
Collaborator
|
You can just mark as draft for things like that. I might also be able to fix it up myself in a couple hours. |
ribbanya
marked this pull request as draft
September 13, 2026 02:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documented most of the parameters within
gr/types.h/GroundParam. Some are still undocumented because changes were not apparent or obvious.Tested via my own tool, ExternalMeleeTool, and the Dolphin debugger. Changed values and observed differences during stage gameplay.