[tools] Enable the 'InlineIsDirectBinding' optimization by default for all platforms. - #26496
Conversation
…r all platforms. It's not possible to load external (unknown at build time) assemblies in .NET, so this shouldn't be a problem. Also I can't see why using the interpreter would cause any problems, so remove that condition too.
There was a problem hiding this comment.
Pull request overview
This PR changes the default optimization settings in the bundler toolchain so that inline-isdirectbinding is enabled by default across all Apple platforms, removing the previous platform- and interpreter-based gating.
Changes:
- Make
InlineIsDirectBindingdefault totrueunconditionally. - Remove the previous conditional logic that disabled the optimization on macOS and when the interpreter is enabled.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
✅ Applied expected app size files from gist. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #b7ef450] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 264 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
It's not possible to load external (unknown at build time) assemblies in .NET, so this shouldn't be a problem.
Also I can't see why using the interpreter would cause any problems, so remove that condition too.
Fixes #6046.