[msbuild] Renumber duplicate error - #26566
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The renumbering is consistent across code and resources and eliminates the duplicate error code without altering runtime behavior beyond the diagnostic ID.
Pull request overview
This PR resolves a duplicate MSBuild error code by renumbering the runtimeconfig JSON-root validation message from E7185 to E7188, ensuring each MSBStrings code maps to a single message across tasks.
Changes:
- Update
MergeRuntimeConfigFilesto logMSBStrings.E7188when the main runtimeconfig file isn’t a valid JSON object. - Move the corresponding resource string in
MSBStrings.resxfromE7185toE7188to eliminate the duplicate key.
File summaries
| File | Description |
|---|---|
| msbuild/Xamarin.MacDev.Tasks/Tasks/MergeRuntimeConfigFiles.cs | Switches the logged error code to the new unique E7188 for invalid runtimeconfig root JSON. |
| msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx | Renumbers the resource entry to E7188 so the error code is no longer duplicated. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11edc6d7-7ba5-4ef5-9f80-5bb7d0db7540
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11edc6d7-7ba5-4ef5-9f80-5bb7d0db7540
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #b6fb345] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 264 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Uh oh!
There was an error while loading. Please reload this page.