Skip to content

Fix MAUI NuGet config pinning when workload feeds fall back - #5302

Merged
matouskozak merged 6 commits into
mainfrom
test-maui-workload-feed-fallback
Sep 9, 2026
Merged

Fix MAUI NuGet config pinning when workload feeds fall back#5302
matouskozak merged 6 commits into
mainfrom
test-maui-workload-feed-fallback

Conversation

@matouskozak

@matouskozak matouskozak commented Sep 7, 2026

Copy link
Copy Markdown
Member

Summary

Share manifest resolution and feed fallback between commit discovery and workload installation. Read package metadata from the selected feed and reuse the resolved manifests during installation.

After dotnet12 was added, commit discovery found no mobile manifests there and used branch-HEAD NuGet configs. Installation separately fell back to dotnet11, so the configs were no longer pinned to the selected package versions.

Use the working-directory NuGet.config for both initial and fallback feed selection, including staged payloads. Pass this path through commit discovery and use the same config finder for uncached installation.

Validation

Internal build 3068838 passed with one Android CoreCLR Release configuration on Pixel8 and one iOS CoreCLR Release configuration on iPhone17 (onlySanityCheck=true).

Internal build 3068905 passed after the config-path correction, with the same two configurations. Both preparation and Helix passed. Logs confirm staged config selection, dotnet11 fallback, three pinned source commits, cached manifest reuse, and successful workload installation.

Temporary local regression checks also passed with different repository and staged config feed lists. No test files or temporary pipeline changes remain in the PR diff.

matouskozak and others added 3 commits September 7, 2026 15:21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 7, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Fallback feed selection in _resolve_manifest_package is tied to the repo-root NuGet.config and can diverge from the NuGet.config discovered/used in CorrelationStaging scenarios, risking incorrect fallback behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR centralizes MAUI workload manifest package resolution (including feed fallback) so commit discovery and workload installation use the same resolved manifest packages and their corresponding feed metadata, preventing NuGet.config pinning mismatches when the latest workload feed lacks mobile manifests.

Changes:

  • Introduced _resolve_manifest_package to resolve the latest manifest package with a fallback feed and return the feed used.
  • Updated _discover_repo_commits to reuse _resolve_manifest_package and cache per-feed NuGet flat container bases.
  • Updated install_latest_maui to reuse _resolve_manifest_package (and cached results from commit discovery) instead of duplicating fallback logic.
File summaries
File Description
src/scenarios/shared/mauisharedpython.py Unifies manifest/feed resolution between commit discovery and workload install to keep workload package selection and NuGet.config pinning consistent across feed fallback.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/scenarios/shared/mauisharedpython.py
matouskozak and others added 3 commits September 7, 2026 16:57
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 7, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change aligns feed fallback and manifest resolution across discovery/install as intended, with only a minor logging clarity nit noted.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread src/scenarios/shared/mauisharedpython.py

@LoopedBard3 LoopedBard3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@matouskozak
matouskozak merged commit c735123 into main Sep 9, 2026
78 checks passed
@matouskozak
matouskozak deleted the test-maui-workload-feed-fallback branch September 9, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants