Repository navigation
Conversation
Signed-off-by: AC <ac@fabtek.cn>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119.
detect_idle_timeoutstill passes a positional client name even thoughinitializeaccepts keyword arguments, and itsensurereferences a variable defined only inside the connection block. The resultingNameErrorprevents the helper from returning an idle interval.Initialize the counter in method scope and pass
name:to the client constructor. Keep the persistent client separate from its underlying Net::HTTP connection so its pool can be shut down on completion or a handled error.The four regression tests run the real constructor with a substituted connection and sleep implementation: reaching the maximum, a zero maximum, EOF after a successful request, and a non-200 response. They verify the returned interval, sleep sequence, and client shutdown. All four raise
NameErrorbefore the fix and pass afterward.Validation (Ruby 3.3.8, Linux arm64):
bundle exec rake test manifest:check: 119 runs, 322 assertions, no failures/errors, 1 skip; manifest check passed.git diff --checkpassed.No live-server idle-timeout measurement was performed; the existing warning about modern Ruby behavior remains. Other Ruby versions and optional net-http-pipeline support were not tested locally. AI assistance: OpenAI Codex investigated, implemented, and ran these checks.