refactor(render): delegate Board screenshot stabilization to SDK - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed
@univer-cli/unit-screenshot@1.0.0-insiders.20260907-70fc579now handles Board connector animation during capture. Remove the duplicate application-side snapshot transformation and pass the loaded source directly to the SDK screenshot capability.Reuse the existing screenshot regression tests for
pages/slidesanimation removal, style preservation and unchanged source data. This changes onlyapps/cli/src/features/render/service.ts; no dependency, README or test changes.Validation:
pnpm checkpassed, including build, tests and package checks.Completes the application follow-up to dream-num/univer-cli-sdk#57 after the SDK upgrade in #50.