Repository navigation
Add canonical 3D surgical deformation bridge - #429
Open
mimosapudical wants to merge 3 commits into
Open
mimosapudical wants to merge 3 commits into
mimosapudical wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a canonical 3D surgical deformation bridge that replaces independent per-view 2D edits with one shared anatomy-space deformation, then reprojects that same edit into each camera view.
This extends #418 beyond reconstruction alone: MediaPipe observations are fit to one canonical face geometry, one 3D surgery is applied, and front / three-quarter / profile outputs become projections of the same underlying intervention.
Type of change
What is included
Supported 3D procedures in this first version:
Validation
Held-out evaluation uses an independent analytic Gaussian 3D deformation field for synthetic ground truth, so the target is not generated by the same Laplacian operator used by Shared 3D.
The canonical fit uses training views only. The held-out post-op target is never used by fitting or deformation.
27-case validation
Across:
with sweep-selected
lambda_smooth=30,lambda_locality=0.3:Maximum synthetic camera-rotation error: ~0.0001°.
The three losses are all rhinoplasty at 20° yaw, where Shared 3D is ~23% worse than the independent 2D preset. The same rhinoplasty deformation improves at 45° and 85°. This limitation is documented rather than hidden by procedure-specific tuning.
A focused 70° / 80° held-out matrix gives 6 / 6 wins with ~23.7% mean relative NME improvement.
How has this been tested?
Added 24 focused Shared 3D tests covering:
These pass on Python 3.10, 3.11, and 3.12.
Static checks on the validated branch:
The repository-wide suite reaches 3579 passed / 1 unrelated existing CodeFormer warning-capture failure on each Python version. This PR does not touch the failing postprocess test or CodeFormer path.
Contributor attribution
This PR also adds mimosapudical to
CONTRIBUTORS.mdfor the canonical 3D surgical deformation bridge, FLAME integration, and held-out multi-view validation.The repository's
CONTRIBUTING.mdrecognition table classifies feature-module contributions as co-author-level contributions for the project paper; final publication authorship remains subject to maintainer acceptance of the contribution.Checklist
Scope
Intentionally out of scope:
Why this is useful
This changes the surgical representation from independent per-view 2D edits to one shared canonical 3D edit, so multi-angle results are linked by geometry instead of by repeated heuristics.
Related issues
Closes #418.