Conversation
… glass For trying the import from a file and from a link, and for seeing what the set format's materials do. Each defines the ten standard dice, so plain notation rolls it once installed. Marble has artwork on every face, and since a drawn face is not printed (decision 96) its numbers are cut into the picture from the app's own printing (DieNumbers), so a d4's corners and a d20's marked 6. sit where a plain die's would. MarbleArtworkTest holds the committed PNGs to the generator; SampleArchivesTest installs every committed zip through PackageInstaller and holds each to its folder byte for byte. The sets live in sample-sets/ rather than examples/: examples/ is a package an author copies and zips, and packages nested in it would ride along and could be installed in its place. The tests read files outside their module, so the folders they read are now declared test inputs; examples/ was not, for ExampleDiceSetTest, and a changed example could replay a cached pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Four finished dice sets for trying the import from a file and from a link, and for seeing what the set format's materials do on the tray. Each defines the ten standard dice, so plain notation (
marble:d20,steel:3d6) rolls it once installed.metallic = 1,density = 7.8, brushedtranslucency = 45: somewhat see-throughtranslucency = 100,roughness = 0.05: clear and polishedWhere things are
sample-sets/<id>/holds each package.sample-sets/<id>.zipis the same folder packed for the file picker, one folder deep.sample-sets/build-archives.pywrites the zips. It needs only Python, and it writes the same bytes on every run.MarbleArtwork(render/filament test sources) draws the marble atlases at 128 px a cell, about 0.8 MB in total.DieNumbers), so a marble d4's corner numbers and a d20's marked6.sit exactly where a plain die's would.DINFINITY_WRITE_EXAMPLES=1 ./gradlew :render:filament:testDebugUnitTest --tests '*MarbleArtworkTest*' --rerun.examples/becauseexamples/is a package an author copies and zips. Packages nested in it would ride along, and the installer takes the firstdiceset.tomlit finds.Tests
SampleArchivesTest(dicesets/install):PackageInstaller(the file-picker path) with no warnings.MarbleArtworkTest(render/filament):ExampleDiceSetTest, which readsexamples/without declaring it, so a changed example could replay a cached pass.verifyDocsIndexandverifyDocsLinkspass.Docs
sample-sets/README.md(what each set shows, how to install from a file or a link, how the files are made and checked).README.md(feature line and doc table),docs/dice-sets.mdandexamples/README.md.docs/STATUS.md, and an owner judgement item indocs/TODO.md4.4.Not done
https://github.com/drehtuer/dInfinityApp/tree/<ref>/sample-sets/<id>works once this is onmain. Until then, use the commit, e.g.…/tree/208958ec/sample-sets/marble. A branch name with a/in it, like this one's, cannot be told apart from the folder path.🤖 Generated with Claude Code