Repository navigation
Shorten the Codex upload skill around a single confirmed upload. - #14
Conversation
upload_file does not create missing parent folders, so the skill asks for an existing path, stops on a name conflict, and sends shared links to the share skill. Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
||
| - Exact destination folder path | ||
| - Target filename and extension | ||
| - Target filename and extension, including the single proposed name when the user did not provide one |
There was a problem hiding this comment.
I don't think I quite understand what "including the single proposed name when the user did not provide one" means?
There was a problem hiding this comment.
That means the confirmation should name the file we are about to upload. If the user already gave a filename, confirm that name. If they did not, propose one filename and extension and include that name in the confirmation, rather than offering several options. I can reword the bullet so that is explicit.
| After a successful upload, return: | ||
|
|
||
| - Full file path in Dropbox | ||
| - Filename and file size when available |
There was a problem hiding this comment.
Do we think most users care for the size to be displayed?
There was a problem hiding this comment.
I don’t think size needs to be part of the normal response. I’ll drop it from the required output and only mention it when the tool returns it.
| 10. Before calling `upload_file`, confirm the exact destination path, filename, and content summary with the user. | ||
| 11. After successful upload, report the file path and offer to create a shared link if appropriate. | ||
| 2. Determine the destination path. If the user named an exact path, use it. Use `search` or `list_folder` only when the folder is ambiguous. | ||
| 3. If the destination folder does not exist, ask the user for an existing folder. `upload_file` does not create missing parent folders. |
There was a problem hiding this comment.
I don't really agree that the LLM should specify it needs an existing folder to the user. If the user wants a new folder the LLM can do that.
There was a problem hiding this comment.
Agreed. The user should be able to ask for a new folder. upload_file will not create a missing parent, but create_folder can. I’ll put that back: if the destination folder does not exist, confirm the path and create it. If a parent along that path is also missing, create that segment first, since create_folder only creates the last path segment
| 5. Before calling `upload_file`, confirm the exact destination path, filename, and content summary with the user. | ||
| 6. After a successful upload, report that the file was created, including the path, filename, and file size when available. | ||
| 7. If `upload_file` returns a name conflict, stop and ask the user before trying another name. | ||
| 8. If the user wants a shared link, switch to `share-dropbox-content`. Do not create a shared link from this skill. |
There was a problem hiding this comment.
Do we want to consider recommending the LLM renders a preview of the file by calling the file_preview tool?
There was a problem hiding this comment.
Yes. After upload_file succeeds, call file_preview so the host can render the file. I originally had the upload_file tool itself open the file preview widget, but at that time it only displayed a loading spinner.
Create missing destination folders after confirmation, preview the file only after upload succeeds, and clarify the filename confirmation. Co-authored-by: Cursor <cursoragent@cursor.com>
upload_file does not create missing parent folders, so the skill asks for an existing path, stops on a name conflict, and sends shared links to the share skill.