Repository navigation
🎨 Primary button text colour follows OKLab lightness with a near-black dark tone - #14
Merged
Merged
Conversation
…k dark tone Replace the WCAG luminance rule in contrastingTextColor(on:in:) with OKLab perceptual lightness (Bjorn Ottosson's public-domain conversion): fills at or below 0.80 take white, lighter ones a near-black (white 0.08) instead of pure black. Add oklabLightness(of:in:) and OnboardingTheme.nearBlack; keep relativeLuminance(of:in:) as a helper. primaryButtonTextColor still overrides. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dryan
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the WCAG luminance rule in contrastingTextColor(on:in:) with OKLab
perceptual lightness (Bjorn Ottosson's public-domain conversion): fills at or
below 0.80 take white, lighter ones a near-black (white 0.08) instead of pure
black. Add oklabLightness(of:in:) and OnboardingTheme.nearBlack; keep
relativeLuminance(of:in:) as a helper. primaryButtonTextColor still overrides.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com