Skip to content

✨ Staged footer reveal, one header icon view with Draw On, and a page-is-current environment value - #15

Merged
dryan merged 1 commit into
mainfrom
onboarding-staging
Oct 13, 2026
Merged

dryan merged 1 commit into
mainfrom
onboarding-staging

Conversation

@dryan-gh-actions

Copy link
Copy Markdown
Contributor

For Marie's onboarding review (dryan-org/podcatcher#92):

  • OnboardingActions.isRevealed (default true): a page that stages its entrance publishes false first and true when its buttons should appear. OnboardingFooter fades between the two over 0.6 s; hidden buttons take no taps; Reduce Motion shows them at once.
  • OnboardingWelcomeView takes actionsRevealed:.
  • OnboardingFlowView sets onboardingPageIsCurrent per page.
  • Every step's header icon is one OnboardingHeaderIcon: drawn at the shared ScaledMetric point size (OnboardingLayout.headerIconSize) through .font instead of .resizable().scaledToFit() at a fixed height, so a wide glyph no longer looks larger than a narrow one; it plays the SF Symbols Draw On effect once each time its page becomes current (symbols without draw annotations fade in; Reduce Motion shows it drawn).

Visible to every app on the kit: header icons size by glyph proportions now and draw on. swift test: 33 and 21 tests pass.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

…-is-current environment value

For Marie's onboarding review (dryan-org/podcatcher#92):

- OnboardingActions.isRevealed (default true): a page that stages its entrance publishes false first and true when its buttons should appear. OnboardingFooter fades between the two over 0.6 s; hidden buttons take no taps; Reduce Motion shows them at once.
- OnboardingWelcomeView takes actionsRevealed:.
- OnboardingFlowView sets onboardingPageIsCurrent per page.
- Every step's header icon is one OnboardingHeaderIcon: drawn at the shared ScaledMetric point size (OnboardingLayout.headerIconSize) through .font instead of .resizable().scaledToFit() at a fixed height, so a wide glyph no longer looks larger than a narrow one; it plays the SF Symbols Draw On effect once each time its page becomes current (symbols without draw annotations fade in; Reduce Motion shows it drawn).

Visible to every app on the kit: header icons size by glyph proportions now and draw on. swift test: 33 and 21 tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dryan-gh-actions
dryan-gh-actions Bot requested a review from a team as a code owner October 13, 2026 19:54
@dryan
dryan merged commit 2dea481 into main Oct 13, 2026
2 checks passed
@dryan
dryan deleted the onboarding-staging branch October 13, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant