Repository navigation
🐛 Footer rebinds its buttons on every page so same-titled pages run their own handlers - #17
Merged
Merged
Conversation
…heir own handlers OnboardingActions equality ignores handlers, and OnboardingFlowView passed the current page's actions to one permanent OnboardingFooter. When two consecutive pages published the same titles, SwiftUI saw equal inputs, skipped the update, and the footer's buttons kept the previous page's closures. Proof (Marie, iPad simulator): tapping Allow on the notifications page ran the analytics page's handler; renaming the analytics button made the system alert appear. The footer is now keyed with .id on the current page, so each page gets its own instance. Within a page the instance is stable, so a page's staged reveal (isRevealed) still fades. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dryan
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the footer running the previous page's handlers when two consecutive pages publish the same button titles.
Cause:
OnboardingActions.==ignores handlers, so the one permanentOnboardingFootersaw equal inputs across the page change and never rebound its buttons.Fix:
.idon the footer keyed by the current page. A new instance per page rebinds the buttons; within a page the instance is stable, soisRevealedfades as before. AnEquatabletoken would have worked too, but would have changed the public type and still relied on SwiftUI diffing.Test:
OnboardingFooterIdentityTestschecks that equal-titled actions compare equal (the premise) while the footer identity differs per page. The view itself is not driven (no UI test target in the kit).After merge: tag 1.3.1.
🤖 Generated with Claude Code