Repository navigation
fix(sdk): point MissingTrustlineError at /api/v1/tx/add-trustline - #1119
Open
solaawojobi00-bit wants to merge 1 commit into
Open
solaawojobi00-bit wants to merge 1 commit into
solaawojobi00-bit wants to merge 1 commit into
Conversation
|
@solaawojobi00-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sdk): point MissingTrustlineError at /api/v1/tx/add-trustline
Problem
MissingTrustlineErrortells API clients to callPOST /api/v1/tx/trustline, a route that does not exist.api/v1/tx/[action].tsmaps"add-trustline"and returns 404 for any other action, so a client following the message gets a 404.Solution
Correct both message variants to name the route the API actually serves.
Changes
packages/stellar-sdk-helpers/src/tx.ts: both message strings now use/api/v1/tx/add-trustline.packages/api-core/src/tx.test.ts: the two assertions on the message text now expect the corrected route.Regression Tests
packages/api-core/src/tx.test.ts(two message assertions, updated)Testing
Notes for Reviewers
Text-only change; no behavior or API surface change. api-core resolves helpers through
dist, so rebuild helpers before running its tests.Closes #1103