Repository navigation
Conversation
not needed, put the methods in the mode_field_plot module
…nter/METplotpy into feature_560_mode_field_plot
…entation. Removed hard-coded pathnames
…onfig which supports ENV vars in yaml config file
…nter/METplotpy into feature_560_mode_field_plot
…bsequent plots using the same data and configuration to ensure no changes have transpired
…o address apply_theta_transforms becoming deprecated in Matplotlib 3.11
|
@bikegeek -- thank for getting this done! I did some minimal testing, and it works! Note, I could have done more extensive testing, but for an initial capability it is great -- and with more DTC testing coming up, I am sure we will be exercising this more. I added some comments above from my human review. Claude also flagged a few things (that I am less knowledgeable about, so I will copy/paste what it said): get_config_value calls a method that doesn’t exist. Any call with more than one key hits The plot_filename logic is broken.
|
| return d | ||
|
|
||
|
|
||
| def build_rgba(self, obj_id, clus_id, color_map, unmatched_color=(0.0, 0.0, 1.0)): |
There was a problem hiding this comment.
Unmatched as blue is good, but tab20 color is a nearby blue (and used elsewhere). It might be good to change tab20 to a more distinctly different blue.
There was a problem hiding this comment.
prompted Claude to find a better colormap, none meet criteria where blues are similar shades. Suggested fix is to remove blues from the tab20 colormap. Now blue for unmatched is the only blue.
…arth_shapefile is set to False. This ensures that the shapefile is in the package-data list to facilitate pip installs.
- mode_obj_file is now the full path to the MODE netCDF file, matching the raw and objects configs; input_dir is removed from the defaults and the config class. - Matched clusters no longer use the blues from tab20/tab20b, so blue only marks unmatched objects. - Update the expected objects test image and the User's Guide figure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…feature_560_mode_field_plot # Conflicts: # metplotpy/plots/taylor_diagram/taylor_diagram.py
The forecast title showed its units twice (from the file and a leftover hard-coded "(mm)"), and the observation title used the forecast units. Each raw panel title now shows its own units once, after the variable name, as the objects titles do. Update the raw User's Guide figure and expected test image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull Request Testing
Describe testing already performed for these changes:
generated pytests to verify plots are generated
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
code is set up on 'seneca': /d1/projects/MODE_Field_Plot with instructions for setting up PYTHONPATH, conda environment to use, and running the plot
User Documentation: ReadtheDocs.io
https://metplus.readthedocs.io/projects/metplotpy/en/feature_560_mode_field_plot
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes]
If yes, please describe:
Quality gate threshold for test coverage may not be met
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases