Repository navigation
Feature 567 scorecard - #595
Open
michelleharrold wants to merge 45 commits into
Open
michelleharrold wants to merge 45 commits into
michelleharrold wants to merge 45 commits into
Conversation
…lculating the scorecard statistics.
…t_init_beg, this causes problems with creating cartesian coordinates. Filtering requires a fcst_vaar, updated in YAML config.
… formatting and appearance.
…reated in the code based on settings in the filtering section. Renamed the ndays setting to sample_size, to make this more clear to users who are not using climate data.
…y scorecard.py from filter settings in the YAML config file and renamed the ndays config value to sample_size.
…feature_567_scorecard
… to METcalcpy agg_stat to calculate the aggregation statistics for the NOAA ECNT data.
…feature_567_scorecard
…ETplotpy into feature_567_scorecard
…ETplotpy into feature_567_scorecard
…feature_567_scorecard
… matplotlib. Also adding SAL1L2 and CNT example XMLs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #567 (Create Python-based Scorecard). Companion PRs: dtcenter/METcalcpy#[N] (SAL1L2 support, #480) and dtcenter/METdataio#[N] (#434).
Builds on the prototype scorecard work started by Minna on this branch.
Summary
scorecard_plot.pyExample configurations
metplotpy/plots/scorecard/gefs_cnt_scorecard.yaml(CNT line type).metplotpy/plots/scorecard/gefs_sal1l2_scorecard.yaml(SAL1L2 line type; requires the companion METcalcpy and METdataio SAL1L2 PRs).Pull Request Testing
Generated scorecards on Derecho/Casper using both example configs (CNT and SAL1L2) with GEFS data. Ran tests using GEFS and AIGEFS data (provided by NOAA/OMD) over March 2026. Example output:
With the companion METdataio and METcalcpy branches on
PYTHONPATH, runscorecard_plot.pywithgefs_cnt_scorecard.yaml, then withgefs_sal1l2_scorecard.yaml. Input data: @bikegeek -- you can use the test GEFS and AIGEFS data on seneca.Example of run commands on Casper:
module load conda
conda activate metplus-dev
ROOT=/glade/derecho/scratch/harrold/scorecard/minnas_work
export PYTHONPATH=$ROOT/METplotpy:$ROOT/METdataio:$ROOT/METcalcpy:$PYTHONPATH
cd $ROOT/METplotpy
python -m metplotpy.plots.scorecard.scorecard_plot
$ROOT/METplotpy/metplotpy/plots/scorecard/gefs_cnt_scorecard.yaml
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? No, this needs extensive documentation of the YAML and functionality. This will be added on the coordinated release cycle.
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by 11/10
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases