Skip to content

Feature 567 scorecard - #595

Open
michelleharrold wants to merge 45 commits into
developfrom
feature_567_scorecard
Open

michelleharrold wants to merge 45 commits into
developfrom
feature_567_scorecard

Conversation

@michelleharrold

Copy link
Copy Markdown

Related to #567 (Create Python-based Scorecard). Companion PRs: dtcenter/METcalcpy#[N] (SAL1L2 support, #480) and dtcenter/METdataio#[N] (#434).

Builds on the prototype scorecard work started by Minna on this branch.

Summary

scorecard_plot.py

  • Retooled to increase functionality and general layout
  • Switched the plotting backend to matplotlib, consistent with the plotly removal in METplotpy 13.0.0 (Remove plotly dependency #555).

Example configurations

  • Adds metplotpy/plots/scorecard/gefs_cnt_scorecard.yaml (CNT line type).
  • Adds metplotpy/plots/scorecard/gefs_sal1l2_scorecard.yaml (SAL1L2 line type; requires the companion METcalcpy and METdataio SAL1L2 PRs).

Pull Request Testing

  • Describe testing already performed for these changes:

Generated scorecards on Derecho/Casper using both example configs (CNT and SAL1L2) with GEFS data. Ran tests using GEFS and AIGEFS data (provided by NOAA/OMD) over March 2026. Example output:

scorecard_example
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

With the companion METdataio and METcalcpy branches on PYTHONPATH, run scorecard_plot.py with gefs_cnt_scorecard.yaml, then with gefs_sal1l2_scorecard.yaml. Input data: @bikegeek -- you can use the test GEFS and AIGEFS data on seneca.

Example of run commands on Casper:
module load conda
conda activate metplus-dev

ROOT=/glade/derecho/scratch/harrold/scorecard/minnas_work
export PYTHONPATH=$ROOT/METplotpy:$ROOT/METdataio:$ROOT/METcalcpy:$PYTHONPATH

cd $ROOT/METplotpy
python -m metplotpy.plots.scorecard.scorecard_plot
$ROOT/METplotpy/metplotpy/plots/scorecard/gefs_cnt_scorecard.yaml

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? No, this needs extensive documentation of the YAML and functionality. This will be added on the coordinated release cycle.

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 11/10

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 30 commits April 1, 2026 12:24
…t_init_beg, this causes problems with creating cartesian coordinates. Filtering requires a fcst_vaar, updated in YAML config.
…reated in the code based on settings in the filtering section. Renamed the ndays setting to sample_size, to make this more clear to users who are not using climate data.
…y scorecard.py from filter settings in the YAML config file and renamed the ndays config value to sample_size.
… to METcalcpy agg_stat to calculate the aggregation statistics for the NOAA ECNT data.
@michelleharrold michelleharrold added this to the METplotpy-13.0.0 milestone Nov 4, 2026
@michelleharrold michelleharrold added reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project labels Nov 4, 2026
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Nov 4, 2026
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

2 participants