Repository navigation
Conversation
Registration now runs PHP's Laravel request rules, with the capability manifest required from protocol 1.18, and then PHP's capability guards in order: prepared local activities, Nexus and cooperative cancellation, the manifest's flag and floor agreement, workflow metadata capabilities and message streams. Refusals carry PHP's fields plus protocol_version and server_capabilities. An unnamed worker gets a ULID, missing type lists are stored empty, and the manifest is stored normalized. The rule engine gains numeric and required_array_keys, and a nested wildcard rule covers only array items, as Laravel's expansion does. The execution tests' router adds the manifest an SDK sends; the new admission tests use the server's own router.
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #325. Stacked on #667; I'll retarget it to
mainonce #667 merges.Gap. Native accepted a registration without the
capability_manifestthat Server 2.10.0 requires from protocol 1.18. It also skipped most of PHP's registration rules and capability guards.Request rules (
WorkerController::register). Laravel's trimming and empty-to-null run first, then PHP's rules with Laravel's 422 messages:runtimemust be one of PHP's values; sizes, capacities, task slots, process metrics and heartbeat interval are checked.local_activities,worker_sessionsandsticky_executionentries, each withsupportedandminimum_protocol_version.numericandrequired_array_keys. A nested*.fieldrule now covers only array items, as Laravel's expansion does.Guards, in PHP's order. Each answers 409 with
registered: false:worker_capability_manifest_mismatchandworker_capability_protocol_floor_mismatch;workflow_metadata_capability_protocol_mismatch, now with PHP'scapability/requested_version/remediationfields instead of native's formerworker_capability/recorded;message_streams_unavailable.Registration refusals carry
protocol_versionandserver_capabilities, asWorkerProtocol::jsondoes.Accepted registrations.
Tests.
tests/execution/worker_admission.rsuses the server's own router. It covers the manifest requirement and its errors, the field rules, the generated id, the stored manifest and every guard.cooperative_cancellationbelow it. They still poll at the protocol each case tests.Results.
Checkpoint:
docs/rust-server-port-checkpoints/2026-10-22-worker-admission.md. The gap list entry is removed.