Repository navigation
Preserve UTC instants and microseconds in visibility queries - #697
Merged
Merged
Conversation
|
rmcdaniel
marked this pull request as ready for review
October 23, 2026 15:08
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Datetime visibility literals are currently passed to Laravel as DateTime objects. SQL preparation formats their local wall time and drops microseconds, so equivalent offsets and neighboring instants return the wrong runs. Bind the existing UTC/microsecond representation before building typed attribute and system timestamp predicates.
This is the separate Server predicate portion of durable-workflow/workflow#898 and complements durable-workflow/workflow#914. It does not change the package pin or repair existing rows.
Validation: a constructed SQLite table cohort executes forty actual Eloquent predicates against five equivalent UTC/offset values, including local-day boundaries, a one-microsecond neighbor, equality/inequality, IN/negated IN, ranges, system StartTime and namespace isolation. Unchanged source fails all forty without query errors; the corrected class passes all forty. The initial fixture used unsupported
Field NOT INsyntax and remains a separate unsuccessful setup; the qualified fixture uses the existingNOT Field INgrammar. Production PHP/SQL dependencies come from the published Server2.11.1 image with only the candidate support class explicitly mounted. This is source-component SQL evidence, not installed acceptance of a new image or a full HTTP test result.Committed API regressions exercise the same cases through the workflow-list route. Fresh exact-head normal CI and network-database/HTTP acceptance remain required. No schema, Composer, release metadata, native/shared/runner/OpenAPI or frozen-actor edit. Existing published-image and security prerequisites are unchanged.