Repository navigation
Rust #325: move the parity reference to published Server 2.11.7 - #867
Merged
Merged
Conversation
Server #812 (#770) makes PHP's Waterline v1 projection count history bytes as Core's HistoryBudget::sizeOfEvent does: the event type's bytes plus its payload encoded with JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE, the unit DW_V2_LIMIT_HISTORY_TRANSACTION_BYTES limits everywhere else. Native, like published PHP through 2.11.5, counted each whole event's JSON with its id, sequence and time and escaped Unicode. Native now uses the canonical unit for the byte limit and for the stored summary's history_size_bytes. #812's LegacyV1Projection::normalize, run on the published 2.11.5 image's Core, counts the bare test source's two events as 1280 and 402 bytes (1682 in all, where the old unit gave 1870); native matches. Hold until the shared fixture reference moves to a Server release carrying #812: the waterline-import fixture records history_size_bytes from the published reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published 2.11.7 (Core 2.15.7) replaces 2.11.5 as the reference the shared fixtures compare native and embedded against (#863). 2.11.6 is skipped: its repeated bridge-adapter update answered 500 (#861, fixed in #862). 2.11.7 counts a v1 projection's history bytes in Core's canonical unit (#770), so waterline-import records five smaller history_size_bytes values. Native already meters the same way (previous commit). No other fixture expectation changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
12 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #863. Part of #325 and #770.
What changes
The shared fixtures compare native and embedded against published Server 2.11.7 (Core 2.15.7) instead of 2.11.5.
tests/Fixtures/ServerParityBaselines/php-2.11.7.jsonrecords:f55f90e5;sha256:be7c2288…;sha256:7dbc3db0….The SDK, CLI, Waterline and sample-app pins are unchanged.
2.11.6 is skipped. Its repeated bridge-adapter update answered
500(Published 2.11.6 answers a repeated bridge-adapter update with 500 #861); Reuse scoped Bridge receipts during external update admission #862 fixed that in 2.11.7.2.11.7 counts a v1 projection's history bytes in Core's canonical unit (Waterline v1 projection import has no event or history byte limit #770, Server Keep v1 projections read-only and bound import history #812): the event type's bytes plus
json_encode(payload, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE).waterline-importand its stored contract observation now record five smallerhistory_size_bytesvalues.Native meters the same way (first commit, held since October 27 for this move), both for the byte limit and for the stored summary.
Local checks (before CI)
service-callsandvisibility-current-runswas recorded against the 2.11.7 amd64 image.bridge-adapterswith the intended answers.schedule-catalogfails locally on 2.11.5 too.waterline-importdiffered only in the five sizes.waterline-import. I recorded it against a fresh 2.11.7 harness and against a native image built from this branch.compareaccepts the pair.PhpImageContextTest, which fails the same way on a cleanmaincheckout here because of local ignored state.The checkpoint has the details.
Not changed here
The
bridge-adapterscontract still accepts the published-defect answers of 2.11.1 to 2.11.5. A follow-up can make it exact now that the reference gives the intended answers.🤖 Generated with Claude Code