Repository navigation
Rust #325: deliver a parent's cooperative cancellation to a retried child - #876
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 30, 2026
A retried child call has a link per attempt, and its call names the latest attempt's run. Native's cooperative cancellation expected one link per call, so it refused a parent's request once a child had been retried. child_link_policies now accepts a retried call's links, and the delivery boundary follows the call to its current run and link, accepting a retry's ChildRunStarted without the call's cancellation policy, as published PHP records it. Under try_cancel the retry run, not the failed first run, is asked to cancel. The retried-child-cancellation fixture records both policies against published 2.11.7. Closes #873. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rmcdaniel
force-pushed
the
rust-325-retried-child-cancellation
branch
from
October 30, 2026 10:23
d2b9c32 to
e2b9f02
Compare
|
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #873. Part of #325. Follows #869 and #874.
What changes
After #869, a retried child call has a link per attempt, and the call names the latest attempt's run. Native's cooperative cancellation expected one link per call. So once a child had been retried, a parent's cancellation request was refused (
422 cooperative_cancellation_propagation_not_available). Security found this in #869's review.Published 2.11.7 admits the request, delivers it at the child boundary, and completes the parent as cancelled:
abandon, the retry keeps running;try_cancel, the parent recordsChildCancellationRequestednaming the retry run, and that run recordsCooperativeCancellationRequested.PHP's retry
ChildRunStartedcarries nocancellation_policy.Native changes:
child_link_policiesaccepts a retried call's links: the first under the call's id, each retry under its own, and earlier attempts.Fixture
retried-child-cancellationRaw worker HTTP on protocol 1.20, with a cooperative parent worker and a separate child worker. There is one case per policy (
abandon,try_cancel). It records:Local checks
retried-child-cancellation. It passes on a fresh published 2.11.7 harness and on native built from this branch, andcompareaccepts the pair.child-retries,parent-close-cancellation,cooperative-before-claim-cleanup,cooperative-pending-timer-cleanupanddirect-child-cancel-pending-timer.a_parents_cooperative_cancellation_reaches_a_retried_child.This PR also corrects two stale lines in the port doc: activity delivery is already served, and the 2.11.5 reference move is done.
Checkpoint.
🤖 Generated with Claude Code