Repository navigation
Preserve recorded activity input during dependency injection - #911
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



An activity changed from
handle(int $amount)tohandle(QuoteRequest $request)could complete with the DTO's default0even though its original recorded input was7. Laravel inserted the DTO and displaced the recorded scalar into an unused extra argument.This change checks dependency resolution before queued and local activity bodies run. Displacing recorded input now produces
ActivityEntryArgumentsMismatchException; resolution exceptions also use the normal activity outcome path. Original input and identity, attempt fencing, authored retry policy and tracing remain intact. Legitimate injected services, defaults and variadics remain supported.With configured retries, restoring a compatible implementation completes the same original activity with its original input. A terminal one-attempt failure retains the normal failed-run behavior; this does not reopen terminal runs or change retry defaults.
Validation completed locally:
0from recorded[7], separately recorded in Do not silently discard recorded activity input during dependency injection #910.Refs #910 and durable-workflow/durable-workflow.github.io#363. The issue stays open until qualified publication and installed-consumer acceptance.
Current source is
912f3e7b790f7d420841739dd01d6513ee495016, whole treeb48b19574b13c369274d986158bf4511041566ca, preparing compatible patch 2.11.3. Its runtime/tests are unchanged from tested 45a6290; only Composer product-train and the changelog were added. No package is published yet.The local MySQL database exited 0 without OOM and was removed with its private network after the eight controls passed. Source-only cleanup does not change the remaining publication/installed-consumer requirements.