Repository navigation
Preserve numeric kinds in CLI history exports - #913
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI history exports serialize whole-valued floats as integers, so their memo projection disagrees with the retained Avro authority and their canonical checksum. The exporter now preserves zero fractions, including signed zero and nested values, in compact and pretty JSON. Fixes #912.
The new regression drives real workflow/activity jobs with original 30-second budgets, exports waiting and completed states, and invokes integrity-only replay verification against the untouched file. It preserves integer values and rejects a deliberately lossy representation without recalculating its checksum.
Validation: all four cases fail against normally installed 2.11.3 and the unchanged parent source; corrected source passes 4 tests / 56 assertions. Focused PHPStan and ECS pass. The initial fixture also compared noncanonical memo map order; the corrected fixture still fails all four parent cases specifically on numeric types. Normal repository checks are qualifying the exact candidate. Compatible 2.11.4 metadata is prepared; nothing is published yet. The independently confirmed Server HTTP transport is separate follow-through in Server #692 / PR #693.