Repository navigation
Add German translation with key and placeholder checks - #104
Open
nawaaaaaAaar wants to merge 2 commits into
Open
nawaaaaaAaar wants to merge 2 commits into
nawaaaaaAaar wants to merge 2 commits into
Conversation
Owner
|
@claude review |
|
Claude finished @dvejsada's task in 22s —— View job Review of PR #104: German translation
Verdict: looks good to merge, with a few optional nits. I found no blocking issues. Translation (
|
Author
|
Addressed the formatting and failure-message nits: de.json now uses the same expanded two-space style as en.json, and parity failures name missing/extra keys. Both offline tests were rerun successfully on Python 3.12 and 3.13. Translation wording is unchanged; native-speaker and live UI review remain explicitly unperformed. The existing Tests workflow does include tests/ once its run is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #97. Add the requested German translation for Knuspr.de and Gurkerl.at users, covering setup, reauthentication, options, selectors, entity names and states. Add offline checks for the complete string-key tree and exact interpolation placeholders.
Verification
python -m unittest discover -s tests -p test_translations.py -v: two tests passed on Python 3.12 and 3.13, with per-string subtests.{email}placeholders remain unchanged.Limits
AI-assisted translation prepared through Perplexity Computer. Native-speaker and live Home Assistant UI review remain valuable; they have not been performed. The Home Assistant integration suite, hassfest and HACS checks are not claimed as local passes. No customer account or credentials were used.