Repository navigation
Improve script confirmer handling and definition parser support; enhance error diagnostics and clean generated parser sources - #34
Merged
Conversation
Keep parser-related changes isolated from DICOM definition content updates. Includes grammar and parser support updates in Definition library sources.
Remove checked-in generated parser outputs (*.cpp, *.cpp.h) under Source/Libraries. These files are generated from grammar/lexer sources and should not be versioned here. This keeps parser generation changes isolated and reduces duplication/merge noise.
Replace exception.Message with exception.ToString() in SopClassesManager to preserve stack trace and exception type in diagnostics. Also normalizes the copyright header symbol encoding.
HealthcareICT
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the latest changes around script confirmer handling and definition file parsing.
It also improves diagnostics when loading definitions fails and cleans up generated parser sources.
Changes
INFO(...)as STRING condition text..defsyntax.Why
Impact
Validation
.deffiles (including unquotedINFO(...)).