Skip to content

Improve script confirmer handling and definition parser support; enhance error diagnostics and clean generated parser sources - #34

Merged
HealthcareICT merged 4 commits into
dvtk-org:masterfrom
bennert:fix-script-confirmer
Aug 6, 2026
Merged

HealthcareICT merged 4 commits into
dvtk-org:masterfrom
bennert:fix-script-confirmer

Conversation

@bennert

@bennert bennert commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR consolidates the latest changes around script confirmer handling and definition file parsing.
It also improves diagnostics when loading definitions fails and cleans up generated parser sources.

Changes

  1. Fixed script parser confirmer interaction handling.
  2. Extended the definition parser to accept unquoted INFO(...) as STRING condition text.
  3. Updated definition lexer/parser to support the new .def syntax.
  4. Removed generated parser source files from Source libraries to reduce duplication and noise.
  5. Included full exception details when definition loading fails.

Why

  1. Improve robustness and predictability of script/confirm interactions.
  2. Support the intended newer definition syntax.
  3. Make troubleshooting easier with richer error details.
  4. Keep the codebase cleaner and easier to maintain by removing generated artifacts.

Impact

  1. Parser behavior changes may affect existing definition/script files.
  2. No broader functional regression is expected outside parsing/confirm flows, but additional validation on existing scripts is recommended.

Validation

  1. Build and smoke-test relevant projects.
  2. Validate parser behavior on representative .def files (including unquoted INFO(...)).
  3. Test script flows involving confirmer interactions.
  4. Verify negative path: definition load failures now surface full exception details.

bennert added 3 commits August 5, 2026 21:11
Keep parser-related changes isolated from DICOM definition content updates.

Includes grammar and parser support updates in Definition library sources.
Remove checked-in generated parser outputs (*.cpp, *.cpp.h) under Source/Libraries.

These files are generated from grammar/lexer sources and should not be versioned here.

This keeps parser generation changes isolated and reduces duplication/merge noise.
Replace exception.Message with exception.ToString() in SopClassesManager to preserve stack trace and exception type in diagnostics.

Also normalizes the copyright header symbol encoding.
@bennert
bennert requested a review from HealthcareICT August 5, 2026 20:27
@HealthcareICT
HealthcareICT merged commit 7b2f02d into dvtk-org:master Aug 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants