Skip to content

[patch] Fix card tests in react19 #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 1 commit into from
Sep 28, 2026
Merged

[patch] Fix card tests in react19 #2552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions packages/lib/src/card/Card.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,19 @@ describe("Card component tests", () => {
expect(cardElement).toHaveAttribute("href", "https://example.com");
});

test("Card renders as a button when onClick is provided", () => {
test("Card renders as a button when onClick is provided", async () => {
const user = userEvent.setup();
const onClickMock = jest.fn();
const { getByRole } = render(<DxcCard onClick={onClickMock}>test-card</DxcCard>);
const cardElement = getByRole("button");
expect(cardElement).toBeTruthy();
expect(cardElement).toHaveTextContent("test-card");
userEvent.click(cardElement);
await user.click(cardElement);
expect(onClickMock).toHaveBeenCalled();
});

test("Card renders as a checkbox when selectable is true", () => {
test("Card renders as a checkbox when selectable is true", async () => {
const user = userEvent.setup();
const onSelectionChangeMock = jest.fn();
const { getByRole } = render(
<DxcCard selectable onSelectionChange={onSelectionChangeMock}>
Expand All @@ -61,7 +63,7 @@ describe("Card component tests", () => {
expect(cardElement).toBeTruthy();
expect(cardElement).toHaveTextContent("test-card");
expect(cardElement).toHaveAttribute("aria-checked", "false");
userEvent.click(cardElement);
await user.click(cardElement);
expect(onSelectionChangeMock).toHaveBeenCalledWith(true);
});

Expand All @@ -75,7 +77,8 @@ describe("Card component tests", () => {
expect(queryByText("test-card")).toBeNull();
});

test("Card with selectable and href should not be selectable", () => {
test("Card with selectable and href should not be selectable", async () => {
const user = userEvent.setup();
const onSelectionChangeMock = jest.fn();
const { getByText } = render(
<DxcCard selectable selected href="https://example.com" onSelectionChange={onSelectionChangeMock}>
Expand All @@ -85,27 +88,29 @@ describe("Card component tests", () => {
const cardElement = getByText("test-card");
expect(cardElement).toBeTruthy();
expect(cardElement.tagName).toBe("A");
userEvent.click(cardElement);
await user.click(cardElement);
expect(onSelectionChangeMock).not.toHaveBeenCalled();
expect(cardElement).toHaveAttribute("href", "https://example.com");
expect(cardElement).not.toHaveAttribute("aria-checked");
});

test("Card keyboard support when it is not selectable", () => {
test("Card keyboard support when it is not selectable", async () => {
const user = userEvent.setup();
const onClickMock = jest.fn();
const { getByRole } = render(<DxcCard onClick={onClickMock}>test-card</DxcCard>);
const cardElement = getByRole("button");
expect(cardElement).toBeTruthy();
expect(cardElement).toHaveTextContent("test-card");
userEvent.tab();
await user.tab();
expect(cardElement).toHaveFocus();
userEvent.keyboard("{Enter}");
await user.keyboard("{Enter}");
expect(onClickMock).toHaveBeenCalled();
userEvent.keyboard(" ");
await user.keyboard(" ");
expect(onClickMock).toHaveBeenCalledTimes(2);
});

test("Card keyboard support when it is selectable", () => {
test("Card keyboard support when it is selectable", async () => {
const user = userEvent.setup();
const onSelectionChangeMock = jest.fn();
const { getByRole } = render(
<DxcCard selectable onSelectionChange={onSelectionChangeMock}>
Expand All @@ -115,11 +120,11 @@ describe("Card component tests", () => {
const cardElement = getByRole("checkbox");
expect(cardElement).toBeTruthy();
expect(cardElement).toHaveTextContent("test-card");
userEvent.tab();
await user.tab();
expect(cardElement).toHaveFocus();
userEvent.keyboard("{Enter}");
await user.keyboard("{Enter}");
expect(onSelectionChangeMock).toHaveBeenCalledWith(true);
userEvent.keyboard(" ");
await user.keyboard(" ");
expect(onSelectionChangeMock).toHaveBeenCalledWith(false);
});
});
Loading