Conversation
- Resolve Proton Northstar paths through Wine drive mappings - Exclude Flatpak output directories from TypeScript checks
Contributor
Author
|
Quick fix with codex for the new northstar errors that we are seeing with r2. Should be accompanied by this fix in the northstar repo which allows it to load absolute paths with the -profile arg. |
Contributor
Author
|
I also tossed in a change in the tsconfig to exclude the flatpak stuff which I think was missed by me initially, but it was causing my tsc to run out of memory from enumerating those files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by GPT-6
Northstar receives a Unix profile path on Linux with Proton and resolves it on the game's Windows drive. Resolve the Northstar directory with
realpath()and prefix it withZ:whenisProton()applies, matching the existing loader patterns. Other platforms and launch types retain their current behavior, and failures returnR2Error.Also exclude generated Flatpak directories through Quasar's
extendTsConfighook. Type checking otherwise scans thousands of bundled JavaScript files from local builds and exhausts Node's heap.Validation:
pnpm typecheckpasses with the default heap, including after a Flatpak build..flatpak; Thomas confirmed it works with the separately patched NorthstarLauncher that supports Windows absolute profile paths.