Repository navigation
feat: prepare signed TestFlight beta archives - #96
Conversation
Add explicit guest and bundled public cloud configuration, validated Release archive inputs, version/build bindings and the UserDefaults privacy declaration. Keep export internal-only and separate from upload. Co-authored-by: OpenAI Codex <noreply@openai.com>
johnnyhuy
left a comment
There was a problem hiding this comment.
Ready from static code review. No required changes found in 9dbc154 against base main at 11a0742.
Standards
No substantive deviations from AGENTS.md or CONTRIBUTING.md found. Configuration stays in the UI-independent package, and the added tests cover the main backend precedence cases.
Spec
The implementation matches the stated preparation scope: explicit guest/cloud selection, bundled release configuration, version/build settings, archive metadata checks and separate internal-only export instructions. No high-confidence correctness or security defect found.
Optional coverage improvement: add mocked main() tests covering generation failure, archive failure and the exact Release/device command arguments. The current Python tests cover helpers rather than subprocess orchestration.
Validation was read-only inspection; no builds, tests or project scripts were executed by this reviewer. Current-head SwiftPM CI passed; iOS build, UI tests and mobile e2e were still running when checked. Signed archive/export and production backend readiness remain subject to the verification gaps stated in the PR.
Standards: 0 required findings. Spec: 0 required findings.
Preserve existing opaque artwork pixels and extend the source icon background to full bleed. Reject transparent source PNGs and non-opaque compiled marketing icons in release preflight. Co-authored-by: OpenAI Codex <noreply@openai.com>
johnnyhuy
left a comment
There was a problem hiding this comment.
Ready from static code review of 2075dae against main at 11a0742. No required changes found.
Standards
No substantive deviations from repository conventions found. The native icon export preserves the source colour profile, handles alpha layout and premultiplication, and checks encoded opaque pixels before writing.
Spec
The full diff matches the preparation scope. Guest/cloud configuration and archive identity checks remain consistent with the earlier review. The new source checks reject alpha/transparency and require a 1024px marketing icon; the archive checks require an opaque compiled marketing rendition. Visual comparison with the unchanged design reference shows the same mark and background with transparent corners filled. All 13 checked-in PNGs report RGB format and their expected dimensions.
Optional improvements: refresh the PR body, which still describes the opaque icon export as outstanding and counts eight Python tests rather than eleven. Use a decodable PNG fixture for the successful PNG-preflight test; the current synthetic fixture omits image data, so it exercises header/transparency inspection only. Xcode asset compilation still provides the actual image decoding gate.
Validation was read-only code and image inspection. No builds, tests or project scripts were executed by this reviewer. Current-head build, UI and e2e CI checks were still running when inspected. Normal Release startup, distribution export and production backend readiness remain separate validation gaps.
Standards: 0 required findings. Spec: 0 required findings.
A TestFlight installation cannot use Xcode launch-scheme environment variables. Main also generated literal app version/build values of 1.0 (1), and its existing PNG app icons contained transparent rounded corners.
This preparation adds an explicit guest or bundled public Supabase backend, binds version/build plist fields to Xcode build settings, and provides a validated Release/device archive workflow. Guest mode ignores cloud values and avoids a missing-development-configuration warning. Existing environment-based development configuration remains available when no release backend is selected. Backend selection for the actual beta is still pending; guest candidates below validate that option only.
mise run ios:archiverequires explicit backend, team, version, build and output. Cloud mode permits only a public HTTPS endpoint and publishable key or anon-role JWT. Local/private endpoints, privileged keys, extra secret fields and invalid build formats are rejected.mise run ios:gen, automatic signing and a redacted saved build log. The archive checks identity/version/backend/privacy metadata and compiled marketing-icon opacity. Export options are local and TestFlight internal-only. Nothing uploads automatically.Local verification on 2075dae passed.
mise run lintpassed, zero serious violations; existing repository warnings remain.mise run buildpassed for the configuration implementation; the icon follow-up changes no package source.mise run testpassed with 11 Python preflight tests, 23 pipeline checks, 169 XCTest tests and 115 Swift Testing tests.git diff --cached --checkpassed before each commit.sipsconfirms source marketing icon has no alpha.assetutiland the new guard confirm its compiled 1024px AppIcon is opaque. The final signed archive did not complete, as explained below.Earlier preparation head 9dbc154 completed a signed guest Release/device archive and a Release simulator build. Archived identity was dev.echohello.BetterFit, 1.7.0 (2611.22.1), with empty cloud fields and the privacy manifest. Strict code-signature verification passed; elevated inspection confirmed team identity, HealthKit/background delivery and Sign in with Apple. That development-signed archive predates the opacity correction and is not the final beta.
All CI checks passed on 9dbc154, including 28 UI tests and the no-demo/no-UI_TESTING guest startup regression. Mobile e2e passed with one known first-launch retry: app did not foreground at e2e/tests/helpers.ts:60, then retry #1 passed; 1 flaky and 3 passed (4.7m), matching #62. Fresh native static review of 2075dae found zero required changes, including the opacity follow-up. Current-head SwiftPM, iOS build, analysis and completed security checks passed. Current-head UI coverage passed all 28 tests with zero failures, including GuestStartupUITests.testNormalLaunchWithoutBackendReachesGuestTabs. Final check state is nine successes and one neutral Socket alert check, with no failures or pending checks. Current-head mobile e2e succeeded with the same first-launch failure at helpers.ts:60, then retry #1 passed: 1 flaky and 3 passed (5.3m). No retry/assertion changes were made for this PR.
The affected icon archive remains incomplete. CodeSign failed with
errSecInternalComponent; Xcode also reported invalid saved-account credentials,missing Xcode-Username. These errors are retained without inferring that keychain state or account expiry alone caused the signing failure. No keychain reset, identity replacement or credential changes were attempted. Xcode Settings > Accounts reauthentication may be needed before retrying signing, through the user's normal secure login flow.An earlier automatic App Store distribution export of unchanged main was attempted with
-allowProvisioningUpdates. Apple returnedUnable to process request - PLA Update available, then a missing distribution-profile error. No agreement was accepted and nothing uploaded. The account holder is reviewing that separately; distribution/profile readiness must be retried after that action rather than presumed still blocked.A bounded fresh-simulator check reached SpringBoard with the Release app installed, but normal launch did not return. On session-owned simulator shutdown the launch ended with IPC error -308; no BetterFit crash report was found. Diagnostics were preserved in temporary files and only the disposable simulator was stopped/removed. The standard local development build also stalled without output for over ten minutes and only its verified process was cancelled. Actual normal Release startup remains unverified locally. Successful build/archive results are not presented as startup proof; the separate normal-launch CI regression passed on the prior head.
Supabase CLI read-only project listing needs login; neither checkout has a linked hosted project reference. Only local loopback configuration and the six-table RLS migration were found. Hosted migration state, production auth/backend choice, App Store Connect app identity/build-number uniqueness, processing/testability and export-compliance answers remain to be verified. Example version/build values above are not a claim of an unused App Store Connect build number.
No CalVer work, unrelated #62/#83 implementation, cloud mutations, tester access, notifications, public links or public App Store release actions are included. Do not merge until the user gives a further instruction, and do not upload the preparation head before it is cleared.