Skip to content

updating vendor submodules to fix build - #108

Merged
n-mat merged 1 commit into
eclipse-adore:developfrom
tlobig:develop
Oct 21, 2026
Merged

n-mat merged 1 commit into
eclipse-adore:developfrom
tlobig:develop

Conversation

@tlobig

@tlobig tlobig commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Description

Updated vendor submodules to fix broken build.

Fixes #(issue-number)

Type of Change

Please delete options that are not relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates documentation)
  • Refactor (non-breaking change for code readability/structure)
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code.
  • I have signed and submitted the Eclipse Foundation Contributors Agreement: https://www.eclipse.org/legal/eca/.
  • My last commit was made with the --signoff flag as required by the Eclipse Foundation.
  • I have commented my code, particularly in hard-to-understand areas and provided a README.md when necessary.
  • I have added tests that prove my fix is effective or that my feature works.
  • Tests pass locally with my changes: (run 'make test' on the ADORe project root to run unit tests).
  • I have updated the documentation in documentation/technical_reference_manual where necessary.
  • I have updated the THIRD-PARTY.md if I have introduced new third-party libraries or dependencies to the project.
  • I have updated the CONTRIBUTERS.md if I wish to acknowledged for my contribution.

How Has This Been Tested?

fixes the build, ran make build and it works

Test Configuration:

  • OS: CachyOS Kernel 7.2.9-2-cachyos (64-bit)
  • Docker Version: 29.9.0

Screenshots (if applicable)

n/a

Related Issues

n/a

Notes for Reviewers

no special information needed

Signed-off-by: Thomas Lobig <thomas.lobig@dlr.de>
@tlobig

tlobig commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

wrong user in commit, redoing the PR

@tlobig tlobig closed this Oct 21, 2026
@tlobig

tlobig commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

reopening, cleared up commit attribution issue (wrong email)

@tlobig tlobig reopened this Oct 21, 2026
@n-mat
n-mat self-requested a review October 21, 2026 09:19

@n-mat n-mat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr fixes build of submodules

@n-mat
n-mat merged commit 369957b into eclipse-adore:develop Oct 21, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants