Skip to content

Table datatest with JUnit - #2693

Open
TruongQuangSB wants to merge 28 commits into
mainfrom
test-tabledata-with-osgi
Open

TruongQuangSB wants to merge 28 commits into
mainfrom
test-tabledata-with-osgi

Conversation

@TruongQuangSB

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Test Results

202 tests  +19   190 ✅ + 7   3m 19s ⏱️ -55s
  5 suites  - 37     0 💤 ± 0 
  5 files    - 37    12 ❌ +12 

For more details on these failures, see this check.

Results for commit cce7665. ± Comparison against base commit ae5f1af.

This pull request removes 184 and adds 201 tests. Note that renamed tests count towards both.
, 2
, a  b c
TableExtensionsTest CompareFootnoteContainer ‑ One single footnote container with unchanged, new and old footnote
TableExtensionsTest CompareTableFootnoteContainer ‑ simple compare planning with one removed and one new footnote
TableExtensionsTest Mix of footnote container types ‑ combined simple and compare footnote containers
TableExtensionsTest Mix of footnote container types ‑ footnote not changed in compare planning
TableExtensionsTest Mix of footnote container types ‑ footnote removed in one container of compare planning but still used in another
TableExtensionsTest Mix of footnote container types ‑ footnotes with overlaps between start-/zielzustand and change in compare planning
TableExtensionsTest SimpleFootnoteContainer ‑ One single footnote container
TableExtensionsTest Special cases ‑ Footnote with no Bearbeitungsvermerk
…
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testExistTableTransformService
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[1] /tmp/set-test12917182144691859832PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[2] /tmp/set-test5959857214707680157Info__2026-04-21_10-40.planpro
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testExistTableTransformService
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testTableControlAreaData(String, PtTable) ESTW-A Linksdorf - ssbb
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testTableControlAreaData(String, PtTable) ESTW-A Linksdorf - ssit
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testTableControlAreaData(String, PtTable) ESTW-A Linksdorf - sska
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testTableControlAreaData(String, PtTable) ESTW-A Linksdorf - sskf
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testTableControlAreaData(String, PtTable) ESTW-A Linksdorf - sskg
org.eclipse.set.feature.table.pt1.test.tabledata.Pt1TableControlAreaDataTest ‑ testTableControlAreaData(String, PtTable) ESTW-A Linksdorf - ssko
…

♻️ This comment has been updated with latest results.

@@ -0,0 +1,13 @@
Lfd. Nr.;A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't the table header here, the header rendere was tested with XSL

@github-actions

This comment has been minimized.

@TruongQuangSB
TruongQuangSB marked this pull request as ready for review September 25, 2026 09:49
@github-actions

This comment has been minimized.

@mariusheine

Copy link
Copy Markdown
Contributor

@TruongQuangSB Can we run these tests in a separate CI job e.g. "integration-tests". This way it is easier to differentiate between "old" unit tests and the migrated swt bot tests. And are the csv references the same as the one from SWT-Bot?

And why did you kept SWTBot-Test here? They should be obsolete now at least in my understanding.

@TruongQuangSB

Copy link
Copy Markdown
Contributor Author

@TruongQuangSB Can we run these tests in a separate CI job e.g. "integration-tests". This way it is easier to differentiate between "old" unit tests and the migrated swt bot tests. And are the csv references the same as the one from SWT-Bot?

And why did you kept SWTBot-Test here? They should be obsolete now at least in my understanding.

  • a separate CI job is good idea.
  • The csv-reference here isn't complete same as SWTBot. This csv isn't contains HTML-Text, it is normal text, no richtext
  • I keep the SWTBot for now, because in this PR the create-difference-table-view isn't implement

@mariusheine

mariusheine commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

@TruongQuangSB Can we run these tests in a separate CI job e.g. "integration-tests". This way it is easier to differentiate between "old" unit tests and the migrated swt bot tests. And are the csv references the same as the one from SWT-Bot?
And why did you kept SWTBot-Test here? They should be obsolete now at least in my understanding.

  • a separate CI job is good idea.

Perfect

  • The csv-reference here isn't complete same as SWTBot. This csv isn't contains HTML-Text, it is normal text, no richtext

And how do we compare red/yellow differences?

  • I keep the SWTBot for now, because in this PR the create-difference-table-view isn't implement

ahh yes. Good point!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@TruongQuangSB

Copy link
Copy Markdown
Contributor Author

@mariusheine the Osgi-test are now in test.yml workflow

@TruongQuangSB

Copy link
Copy Markdown
Contributor Author

@mariusheine before you merge this PR, you should see this #2843

@github-actions

This comment has been minimized.

@mariusheine

Copy link
Copy Markdown
Contributor

@mariusheine before you merge this PR, you should see this #2843

And which one should we merge first now? 😆

@TruongQuangSB

Copy link
Copy Markdown
Contributor Author

@mariusheine before you merge this PR, you should see this #2843

And which one should we merge first now? 😆

@mariusheine you should merge #2843 first. This will be merge to this PR not to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants