Repository navigation
Conversation
…#771, eclipse-threadx#772) Support passing full pointer-width context arguments to thread and timer callbacks on 64-bit architectures without truncation, while maintaining full backward compatibility for existing 32-bit ULONG callbacks. Signed-off-by: Dev dev <kalpanagola9897@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #771, fixes #772
In 64-bit systems, pointers were getting cut off when passed to thread and timer callbacks because ThreadX was using 32-bit ULONG for them. To solve this without breaking any old code, I changed the internal callback parameter fields to ALIGN_TYPE so they can hold a full 64-bit pointer. I added new tx_thread_create_ptr and tx_timer_create_ptr functions to pass pointer contexts safely, and added the TX_ENABLE_POINTER_CALLBACKS option to let users use pointers with the standard create functions. I updated both the regular and SMP code, tested the builds, and confirmed that pointer contexts are now passed properly without any truncation.