Usubscription v4 - #358
Usubscription v4#358AnotherDaniel wants to merge 7 commits into
Conversation
AnotherDaniel
commented
Jul 20, 2026
AnotherDaniel
commented
- implement all changes required to support usubscription spec v4
- some dependency version bumps
|
@AnotherDaniel I have put most (if not all) of your proposed crate updates into a separate PR (#362). Can you take a look, approve and then rebase this PR? |
cf79e80 to
d877e7b
Compare
|
@AnotherDaniel can you also resolve the conflicts with main? |
d877e7b to
68252c8
Compare
68252c8 to
da85a53
Compare
d397956 to
0d26414
Compare
0d26414 to
a1c12c4
Compare
AnotherDaniel
added
enhancement
7e88b58 to
55bfc9a
Compare
| .into(), | ||
| }, | ||
| ..Default::default() | ||
| let subscription_request = SubscribeRequest { |
There was a problem hiding this comment.
FMPOV we should do some parameter validation here, e.g. check if expiration is in the past or sample_period is negative, is the topic really a topic?
There was a problem hiding this comment.
Did you add some validation logic? I cannot seem to find/see it ...
|
It seems like you didn't push any of the changes that you mentioned in the comments ... |
Yes, you're right. git mishap - should be back now. |
3e23c62 to
b82ed96
Compare
| /// at a high rate. If the desired sampling period set by the subscriber is lower than the original publisher's | ||
| /// publication period, the attribute is ignored. | ||
| /// If not specified, the sampling period is set by the publisher. | ||
| /// TimeDeltas used in `min_sample_period` will be clamped to [0; u32::MAX] milliseconds. |
There was a problem hiding this comment.
What is the meaning of a TimeDelta of 0? In fact, who cares about this value anyway? The streamer? The publishing uEntity will most likely not care at all, right?
Is there a (reasonable) minimal delta that we would like to impose, maybe something like 100ms? We are talking about remote topics only here, right?
There was a problem hiding this comment.
Fair point, but I'd rather have the underlying discussion in up-spec context, before we address the language library.
| .into(), | ||
| }, | ||
| ..Default::default() | ||
| let subscription_request = SubscribeRequest { |
There was a problem hiding this comment.
Did you add some validation logic? I cannot seem to find/see it ...
2 participants
