Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Collaborator
|
AcknowlEDG review results updated for
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the fixed underlying integer type when emitting scoped enumerations through the C-generating back end. Scoped enum bit fields also retain the signedness of that underlying type.
Related discussion: #296
Previously accepted by Mike Herrick as issue EDGcpfe/28934.
Adds runtime checks for negative values, empty scoped enums, and signed, unsigned, and bool enum bit fields, plus front-end underlying-type checks. The regression program exits 0 with GCC 13.
EDG build, regression testing, and test recordings are pending because the Docker development environment is unavailable. This PR is a draft until those checks are completed.