Fix(Processes): Make subterm hoisting deterministic across processes - #422
Open
wjrforcyber wants to merge 2 commits into
Open
Fix(Processes): Make subterm hoisting deterministic across processes#422wjrforcyber wants to merge 2 commits into
wjrforcyber wants to merge 2 commits into
Conversation
Signed-off-by: JingrenWang <wjrforcyber@163.com>
for more information, see https://pre-commit.ci
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
serialize()output (and the internal$__expr_Nlet-numbering / e-class ids) differ between processes for byte-identical input programs._exprs_multiple_parents()traversed the expression graph with a set ofTypedExprDeclobjects and.pop()ed from it. Popping from a set of objects followsid()-basedhashing — i.e. memory addresses — so the traversal order (and with it the order/decision in which shared subterms were hoisted into$__expr_Nlet-bindings) varied per process. Identical programs were therefore lowered into different (equivalent) e-graphs.Fix
Traverse with a deterministic LIFO worklist (list +
.pop(), children via.extend()) instead of a set.Test
Builds an expression with many shared (multi-parent) subterms, lowers it in 3 fresh subprocesses, and asserts the serialized output hash is identical.