Repository navigation
fix(ci): restore missing build_type check in release pipeline - #504
Merged
Merged
Conversation
The outer `if [[ "$BUILD_TYPE" == "release" ]]` guard was accidentally dropped in #503, leaving the branch pattern check unconditional. Any Snapshot build triggered from main would hit the N.N branch guard and exit 1 with a misleading "Release builds require an N.N branch" error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
seanstory
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in #503 where the outer
if [[ "$BUILD_TYPE" == "release" ]]guard was accidentally dropped from the "Resolve build type" step.Bug: The branch pattern check (
^[0-9]+\.[0-9]+$) ran unconditionally, so any Snapshot build triggered frommainwould fail immediately with a misleading error:Fix: Restore the missing
if [[ "$BUILD_TYPE" == "release" ]]; thenwrapper so the branch guard only runs for Release builds.Test plan
mainwith default Snapshot settings → confirm SNAPSHOT image published (was broken before this fix)mainand choose "Release" → confirm it is rejected1.0with "Release" → confirm release image published🤖 Generated with Claude Code