Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved: no actionable issues found at or above the review threshold.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
SearchDropdownHeader and the Codex hero rule are dead. They confuse the next change. Leave the FinishExportAsync temporary comment for the separate #724 work. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com>
reakaleek
force-pushed
the
feat/remove-jump-to-page-leftovers
branch
from
September 18, 2026 12:23
b720b1b to
8cda711
Compare
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4148/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete unused `SearchDropdownHeader` and the Codex hero `navigation-search` rule. The `FinishExportAsync` temporary comment stays for elastic/docs-eng-team#724.
Affects: Site UI
Prompt summary: Fifth stacked PR for the Jump to page API story. Implement elastic/docs-eng-team#861 on top of elastic/docs-builder#4147: remove leftovers. Do not implement elastic/docs-eng-team#724.
Stack: 5 of 5, on top of #4147.
Why
`SearchDropdownHeader.tsx` is unused. `codex.css` still styles `navigation-search` in the Codex hero. Those leftovers confuse the next change.
Closes elastic/docs-eng-team#861
What
Unused header
`SearchDropdownHeader.tsx` is deleted. Nothing imported it.
Codex CSS
The `.codex-hero navigation-search` rule is gone. `codex.css` has no `navigation-search` selector.
Left alone
The `FinishExportAsync` temporary comment stays. That work belongs to elastic/docs-eng-team#724.
Verify
Made with Cursor