use Sigils RChan for image messages - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move RChan ownership and storage into Sigils and update FigDraw image messaging to consume it.
FigDraw now requires the Sigils
feat/rchannelsbranch while that dependency PR is reviewed, and keepsfigdraw/common/rchannelsas a compatibility import. The previous local implementation and its dedicated test file are removed; the full ownership/concurrency suite lives in Sigils. Image loading adds a bounded-ring integration test that pushes 4,300 managed replacement frames and verifies the newest frame survives overwrite.This PR depends on elcritch/sigils#60. After that PR is merged and released as 0.31.0, the FigDraw requirement can switch from the review branch to the released version.
Validation: