Repository navigation
Conversation
BlackHole1
reviewed
Oct 22, 2026
|
coverage: 87.363% (+0.02%) from 87.341% — a5768549:fix/disable-ia32-armv7l-electron-44 into electron:main |
BlackHole1
approved these changes
Oct 22, 2026
Electron no longer publishes win32-ia32 or linux-armv7l binaries starting with v44 (the last prerelease with them is 44.0.0-alpha.3). Fiddle still offered those versions on ia32 and armv7l installs and tried to download artifacts that don't exist. Disable the download for 44.0.0-alpha.4 and above on those architectures, the same way older versions are disabled on Apple Silicon and Windows arm64. Fixes electron#2023 Co-Authored-By: Claude <noreply@anthropic.com>
Replace the chained platform/arch conditions in disableDownload with a
lookup from `${platform}-${arch}` to the rule for that combination, as
suggested in review. Behaviour is unchanged.
Co-Authored-By: Claude <noreply@anthropic.com>
BlackHole1
force-pushed
the
fix/disable-ia32-armv7l-electron-44
branch
from
October 22, 2026 07:59
183278b to
05b0680
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2023.
Electron no longer publishes prebuilt binaries for 32-bit Windows (
win32-ia32) or 32-bit ARM Linux (linux-armv7l) starting with v44 (breaking changes). Fiddle still offered those versions on ia32 and armv7l installs, so it tried to download artifacts that don't exist, e.g.electron-v44.5.1-win32-ia32.zipfrom the issue.I checked the release assets to find the cutoff:
electron-v44.0.0-alpha.3-win32-ia32.zipandelectron-v44.0.0-alpha.3-linux-armv7l.zipexist, and neither thewin32-ia32nor thelinux-armv7lzip exists forv44.0.0-alpha.4,v44.0.0-alpha.5,v44.0.0,v45.0.0-alpha.1or the latest nightly (v46.0.0-nightly.20261021).This adds that case to
disableDownload(): onwin32/ia32andlinux/arm, versions>=44.0.0-alpha.4can't be downloaded. That reuses the existing handling for Apple Silicon and Windows arm64, so those versions show as disabled in the version picker and settings instead of failing to download. Local builds aren't affected.Tests
tests/renderer/utils/disable-download.spec.tscovering the alpha.3/alpha.4 boundary, a stable 44 release and a nightly. They fail without the change and pass with it.disable-download,version-select,settings-electronandremote-loaderspecs pass (64 tests);oxlint, Prettier andtsc --noEmitare clean.